Ravi Nori has posted comments on this change. Change subject: core: CommandBase - avoid releasing lock if there is a callback ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40248/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1934: Line 1935: private void freeLockExecute() { Line 1936: if (releaseLocksAtEndOfExecute || !getSucceeded() || Line 1937: (!hasTasks() && !(this instanceof IVdsAsyncCommand) && getCallBack() == null)) { Line 1938: freeLock(); Fine with me but we have make sure LiveMerge and any other commands with callback release locks in their call backs. Please test for regression Line 1939: } Line 1940: } Line 1941: Line 1942: -- To view, visit https://gerrit.ovirt.org/40248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a21b3d1e72344f85d5a2469bb07eda864174bac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
