Ravi Nori has posted comments on this change. Change subject: core: CommandBase - mark command status only if there is no callback ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40249/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1392: } Line 1393: } finally { Line 1394: if (getCallBack() == null && !hasTasks() && !ExecutionHandler.checkIfJobHasTasks(getExecutionContext())) { Line 1395: ExecutionHandler.endJob(getExecutionContext(), getSucceeded()); Line 1396: setCommandStatus(getSucceeded() ? CommandStatus.SUCCEEDED : CommandStatus.FAILED); The status is already being set to SUCCEEDED in finally of executeWithoutTransaction. We don't need it here Line 1397: } Line 1398: } Line 1399: } Line 1400: } -- To view, visit https://gerrit.ovirt.org/40249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986e1c7b241d342d39aae82ee3441b2412a48471 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
