Eli Mesika has posted comments on this change. Change subject: core: backup awareness refactoring ......................................................................
Patch Set 1: (6 comments) https://gerrit.ovirt.org/#/c/40389/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java: Line 27: private String scope; Line 28: Line 29: @Id Line 30: @Column(name="done_at") Line 31: private Date doneAt; > I wonder why we use here scope and doneAt attributes instead of having Engi Following our talk I am new to JPA and failed to implement that We agreed that you will give some directions how should it be done Line 32: Line 33: @Column(name="is_passed") Line 34: private boolean passed; Line 35: Line 105: return true; Line 106: } Line 107: if (obj == null) { Line 108: return false; Line 109: } > Please remove construct: Done Line 110: if (!(obj instanceof EngineBackupLog)) { Line 111: return false; Line 112: } Line 113: EngineBackupLog other = (EngineBackupLog) obj; Line 111: return false; Line 112: } Line 113: EngineBackupLog other = (EngineBackupLog) obj; Line 114: return (Objects.equals(scope, other.scope) Line 115: && Objects.equals(doneAt, other.doneAt)); > Please remove unnecessary parenthesis: Done Line 116: } Line 117: Line 118: @Override Line 119: public String toString() { https://gerrit.ovirt.org/#/c/40389/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java: Line 35: Line 36: @Override Line 37: public boolean equals(Object obj) { Line 38: if (this == obj) Line 39: return true; > Please always use parenthesis: Done Line 40: if (obj == null) Line 41: return false; Line 42: if (!(obj instanceof EngineBackupLogId)) { Line 43: return false; Line 37: public boolean equals(Object obj) { Line 38: if (this == obj) Line 39: return true; Line 40: if (obj == null) Line 41: return false; > Please remove construct: Done Line 42: if (!(obj instanceof EngineBackupLogId)) { Line 43: return false; Line 44: } Line 45: EngineBackupLogId other = (EngineBackupLogId)obj; Line 42: if (!(obj instanceof EngineBackupLogId)) { Line 43: return false; Line 44: } Line 45: EngineBackupLogId other = (EngineBackupLogId)obj; Line 46: return (scope.equals(other.getScope()) && doneAt.equals(other.getDoneAt())); > Please remove unnecessary parenthesis: what is the advantage here ? Line 47: } Line 48: Line 49: Line 50: } -- To view, visit https://gerrit.ovirt.org/40389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c4a5372a9108d8c4d5960112f27a0b94f3b654 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
