Eli Mesika has posted comments on this change. Change subject: core: backup awareness refactoring ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40389/2/packaging/dbscripts/upgrade/03_06_1320_backup_extensions.sql File packaging/dbscripts/upgrade/03_06_1320_backup_extensions.sql: Line 1: select fn_db_add_column('engine_backup_log', 'fqdn', 'varchar(255)'); Line 2: select fn_db_add_column('engine_backup_log', 'log_path', 'text'); Line 3: select fn_db_rename_column('engine_backup_log', 'db_name', 'scope'); > wouldn't you rather using the column type as enum ? especially since the va I don't think so "files" for example are not handled at all by engine and still a record should be created when this is sent as the scope And I want engine-backup to be able to add any other scope value without touching the engine at all Since the only component causing records to be inserted to engine_backup_log table is engine-backup, I think that we can trust it for putting in the scope valid data Such validation as you suggested are mainly when manual intervention is involved -- To view, visit https://gerrit.ovirt.org/40389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c4a5372a9108d8c4d5960112f27a0b94f3b654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
