Eli Mesika has posted comments on this change. Change subject: core: VirtIO console access key management ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/39512/12/packaging/dbscripts/upgrade/03_06_1280_attach_edit_profile_permission.sql File packaging/dbscripts/upgrade/03_06_1280_attach_edit_profile_permission.sql: Line 11: INSERT INTO roles(id,name,description,is_readonly,role_type, app_mode) Line 12: SELECT v_EDIT_USERPROFILE_USER_ID, 'EditUserProfileUser', 'Edit UserProfile User', true, 2, 255 Line 13: WHERE NOT EXISTS (SELECT id,name,description,is_readonly,role_type Line 14: FROM roles Line 15: WHERE id = v_EDIT_PROFILE_USER_ID > its enough to look by UUID, its unique.. IMO , you don't need a "WHERE" clause here since scripts are not re-entrant , so , if this role is new it is certainly not there I would remove the whole "WHERE" Line 16: AND name='EditUserProfileUser' Line 17: AND description='Edit UserProfile User' Line 18: AND is_readonly=true Line 19: AND role_type=2 -- To view, visit https://gerrit.ovirt.org/39512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
