Roy Golan has posted comments on this change. Change subject: engine: On vm replacement vialidate vm Numa config match host Numa config ......................................................................
Patch Set 2: (4 comments) what do you want to do with this code? https://gerrit.ovirt.org/#/c/38770/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 710: isReplacingNumaPinnedVm extract this to VmValidator Line 714: question for review: is it saf totally unsafe Line 716: // empty, shell we fix? no, its emppty cause it didn't run yet or wasn't shutdown or didn't migrated Line 746: boolean retVal = false; // debug variable for error testing : return retVal; its hard to review this. -- To view, visit https://gerrit.ovirt.org/38770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32c7fede611dd3d1d0efeaae41f57f8273b7e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
