Roy Golan has posted comments on this change. Change subject: engine: On vm replacement vialidate vm Numa config match host Numa config ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38770/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 739: } Line 740: Line 741: return retVal; Line 742: } Line 743: > Review question: Maybe we want to push this function to eclectic class VmHa indeed. also please shorted the method name Line 744: protected boolean isDedicatedVdsExistOnSameCluster(VmBase vm, Line 745: ArrayList<String> canDoActionMessages) { Line 746: return VmHandler.validateDedicatedVdsExistOnSameCluster(vm, canDoActionMessages); Line 747: } -- To view, visit https://gerrit.ovirt.org/38770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32c7fede611dd3d1d0efeaae41f57f8273b7e37 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
