Martin Mucha has posted comments on this change. Change subject: restapi: Add support for Network Attachements. ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/32775/23/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java: Line 22: } Line 23: Line 24: if (model.isSetNetwork() && model.getNetwork().isSetId()) { Line 25: entity.setNetworkId(GuidUtils.asGuid(model.getNetwork().getId())); Line 26: } > What about the network name? Won't we support specifying the network by nam since I'm not sure if others will agree with this, I added support for identifying networks by name to separate patch. Please lets continue with discussion about this here: https://gerrit.ovirt.org/40359 Done Line 27: Line 28: if (model.isSetHostNic()) { Line 29: HostNIC hostNic = model.getHostNic(); Line 30: if (hostNic.isSetId()) { -- To view, visit https://gerrit.ovirt.org/32775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ac91eea1000f7fdf6105777343a1ac1c77368d Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
