Martin Mucha has posted comments on this change. Change subject: restapi: Add support for Network Attachements. ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/32775/23/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3985: </xs:extension> Line 3986: </xs:complexContent> Line 3987: </xs:complexType> Line 3988: Line 3989: <xs:element name="ip_configuration" type="IpConfiguration"/> > If I understand correctly you have several IP addresses associated to a net I'm very sorry about this. I did not check whether 'primary' element/attribute is used, and it wasn't. I just deleted it and moved boot_protocol (which I do not know why it's part of ip collection), so I can entirely reuse ip and ips elements. Done. Line 3990: Line 3991: <xs:complexType name="IpConfiguration"> Line 3992: <xs:sequence> Line 3993: <xs:element ref="ipv4s" minOccurs="0" maxOccurs="1"> -- To view, visit https://gerrit.ovirt.org/32775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ac91eea1000f7fdf6105777343a1ac1c77368d Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
