Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: all disks were by default bootable for instance images ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40317/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java: Line 249: attachCommand.setIsAvailable(false); Line 250: Line 251: fillData(); Line 252: Line 253: Disk disk = super.getDisk(); please note the "super".getDisk() is there to please the findbugs Line 254: if (disk.getDiskStorageType() == DiskStorageType.IMAGE || disk.getDiskStorageType() == DiskStorageType.CINDER) { Line 255: ((DiskImage) disk).setActive(true); Line 256: } Line 257: } -- To view, visit https://gerrit.ovirt.org/40317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb699b2c1d8c2124b69d8032eefd8ba8e185844f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
