Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: all disks were by default bootable for instance images ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40317/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java: Line 254: true > this value is only set on backend, why is it needed here? Because the AbstractDiskModel.updateBootableFrom() on line 481 checks if the disk is not a snapshot (which for image means it is active). And only disallows you to set other disk to be bootable if there is an active disk which already is bootable. Since this disk does not yet exist (in this method we only create a disk object and the disk will be created on submitting of the whole VM dialog) we can expect that it will become active so we can set it to active here so no other disks can be set to bootable. -- To view, visit https://gerrit.ovirt.org/40317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb699b2c1d8c2124b69d8032eefd8ba8e185844f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
