Moti Asayag has posted comments on this change.
Change subject: webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface
from nic
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
Line 90: }
Line 91: }
Line 92:
Line 93: public void detach() {
Line 94: boolean setNetToDcValues = false;
perhaps 'resetUnsyncNetwork' or 'syncNetworkValues' will serve this purpose
better.
Line 95: if (!isInSync() && isManaged()){
Line 96: getSetupModel().getNetworksToSync().add(getName());
Line 97: setNetToDcValues = true;
Line 98: }
--
To view, visit http://gerrit.ovirt.org/8361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb0d9e6d4f3316300633eaa4602f50c9a16fe53f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
