Alona Kaplan has uploaded a new change for review. Change subject: webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface from nic ......................................................................
webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface from nic https://bugzilla.redhat.com/863109 When there is unsynced network with VLAN (on rhevm the network is with VLAN and on the host the network is without VLAN) it is impossible to detach the network from the nic using SetupNetworks. Change-Id: Ibb0d9e6d4f3316300633eaa4602f50c9a16fe53f Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/8361/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java index 4b251ef..52e3438 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java @@ -91,9 +91,10 @@ } public void detach() { + boolean setNetToDcValues = false; if (!isInSync() && isManaged()){ getSetupModel().getNetworksToSync().add(getName()); - setNetworkToDcValues(); + setNetToDcValues = true; } assert attachedToNic != null; @@ -135,6 +136,10 @@ nicEntity.setType(0); } + if (setNetToDcValues){ + setNetworkToDcValues(); + } + } private void setNetworkToDcValues() { -- To view, visit http://gerrit.ovirt.org/8361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb0d9e6d4f3316300633eaa4602f50c9a16fe53f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
