Moti Asayag has posted comments on this change. Change subject: core: using JPA for engine backup awareness ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40091/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java: Line 96: && this.passed == other.passed : && Objects.equals(outputMessage, other.outputMessage) > 1. Now, when we move to JPA that might be a problem. 1. in addition to 1, should we access the data members directly or any access should be done via the getter methods which are probably wrapped by the entities proxies ? 2. :-) just saying there is a lot of work on that area. Perhaps the right thing to do it to tie it to moving to JPA effort. https://gerrit.ovirt.org/#/c/40091/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java: Line 44: } Line 45: EngineBackupLog other = (EngineBackupLog)obj; Line 46: return (dbName.equals(other.getDbName()) && doneAt.equals(other.getDoneAt())); Line 47: } Line 48: while at at, there is an extra space line. Line 49: Line 50: } Line 51: -- To view, visit https://gerrit.ovirt.org/40091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aa9c4d0c8c0a5f7b40a022d7670f30c5fd5b77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
