Eli Mesika has posted comments on this change. Change subject: core: using JPA for engine backup awareness ......................................................................
Patch Set 6: -Verified (3 comments) https://gerrit.ovirt.org/#/c/40091/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoDbFacadeImpl.java: Line 17: } Line 18: Line 19: @Override Line 20: public EngineBackupLog getLastSuccessfulEngineBackup(String dbName) { Line 21: TypedQuery query = entityManager.createNamedQuery("EngineBackupLog.getLatest", EngineBackupLog.class).setParameter("dbName", dbName); > please use formatter. this line exceeds 120 chars. Done Line 22: query.setMaxResults(1); Line 23: EngineBackupLog log = singleResult(query); Line 24: return log; Line 25: } Line 21: TypedQuery > TypedQuery, as its name reminds, is parameterized, so please use TypedQuery Done Line 18: Line 19: @Override Line 20: public EngineBackupLog getLastSuccessfulEngineBackup(String dbName) { Line 21: TypedQuery query = entityManager.createNamedQuery("EngineBackupLog.getLatest", EngineBackupLog.class).setParameter("dbName", dbName); Line 22: query.setMaxResults(1); > +1 Moti Done Line 23: EngineBackupLog log = singleResult(query); Line 24: return log; Line 25: } -- To view, visit https://gerrit.ovirt.org/40091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aa9c4d0c8c0a5f7b40a022d7670f30c5fd5b77 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
