Omer Frenkel has posted comments on this change. Change subject: events: vm stats refresher refactioring ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/37487/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java: Line 47: Line 48: @Override Line 49: @OnTimerMethodAnnotation("perform") Line 50: public void perform() { Line 51: if (this.manager.isMonitoringNeeded()) { > There are no logical changes in the code. My intention was to have exactly i'm sorry i wasn't clear, my comment was about using "this" keyword: "this.manager.isMonitoringNeeded()" instead just "manager.isMonitoringNeeded()" Line 52: VmsListFetcher fetcher = Line 53: getRefreshStatistics() ? Line 54: new VmsStatisticsFetcher(this.manager) : Line 55: new VmsListFetcher(this.manager); -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
