Omer Frenkel has posted comments on this change. Change subject: events: vm stats refresher refactioring ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/37487/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-27 15:18:29 +0100 Line 4: Commit: pkliczewski <piotr.kliczew...@gmail.com> Line 5: CommitDate: 2015-04-23 09:41:33 +0200 Line 6: Line 7: events: vm stats refresher refactioring please add some (short) info about what this patch is doing and why Line 8: Line 9: Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 https://gerrit.ovirt.org/#/c/37487/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java: Line 47: Line 48: @Override Line 49: @OnTimerMethodAnnotation("perform") Line 50: public void perform() { Line 51: if (this.manager.isMonitoringNeeded()) { why are you using this.manager? although its a style preference i think it should be removed Line 52: VmsListFetcher fetcher = Line 53: getRefreshStatistics() ? Line 54: new VmsStatisticsFetcher(this.manager) : Line 55: new VmsListFetcher(this.manager); https://gerrit.ovirt.org/#/c/37487/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 886: } Line 887: } Line 888: Line 889: public boolean getRefreshStatistics() { Line 890: if (this.vmsRefresher == null) { same comment about using "this" Line 891: return false; Line 892: } Line 893: return this.vmsRefresher.getRefreshStatistics(); Line 894: } -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
