Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
......................................................................
Patch Set 11: (3 inline comments)
OK... few minor comments.
....................................................
File packaging/fedora/setup/common_utils.py
Line 659: inDbAdminSection = False
Line 660: inDbUserSection = False
Line 661: if os.path.exists(basedefs.DB_PASS_FILE):
Line 662: logging.debug("found existing pgpass file %s, fetching DB %s
value", basedefs.DB_PASS_FILE, param)
Line 663: with open(basedefs.DB_PASS_FILE, 'r') as pgPassFile:
I think the 'r' is default, not that it is that matter...
Line 664: for line in pgPassFile:
Line 665:
Line 666: # find the line with "DB ADMIN"
Line 667: if basedefs.PGPASS_FILE_ADMIN_LINE in line:
Line 670:
Line 671: if inDbAdminSection and param == "admin" and \
Line 672: not line.startswith("#"):
Line 673: # Means we're on DB ADMIN line, as it's for
all DBs
Line 674: dbcreds = line.split(":", 4)
This is two indents... does it pass pyflakes/pep8?
Line 675: return dbcreds[field[param]]
Line 676:
Line 677: # Fetch the password if needed
Line 678: if param == "password" \
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 442: self.updated = False
Line 443: self.dbrenamed = False
Line 444: self.name = basedefs.DB_NAME
Line 445:
Line 446:
Remove.
Line 447: def __del__(self):
Line 448: if self.updated:
Line 449: logging.debug(MSG_INFO_DB_BACKUP_FILE + self.sqlfile)
Line 450: print "* %s %s" % (MSG_INFO_DB_BACKUP_FILE, self.sqlfile)
--
To view, visit http://gerrit.ovirt.org/8135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d44297725d7270982e8724e4aeefda8bc7a88e2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
