Alex Lourie has posted comments on this change. Change subject: packaging: updated handling of pgpass file between versions ......................................................................
Patch Set 7: (4 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 918 Line 919 Line 920 Line 921 Line 922 legacy code .................................................... File packaging/fedora/setup/engine-cleanup.py Line 356: dbHost=DB_HOST, Line 357: dbPort=DB_PORT, Line 358: dbName=basedefs.DB_NAME, Line 359: sqlQuery="select 1", Line 360: envDict=self.env, Done Line 361: ) Line 362: if rc != 0: Line 363: if utils.verifyStringFormat(out,".*FATAL:\s*database\s*\"%s\"\s*does not exist" % (PREFIX)): Line 364: # This means that the db is not installed, so we return false .................................................... File packaging/fedora/setup/engine-upgrade.py Line 776: dbName=basedefs.DB_NAME, Line 777: sqlQuery=queryCheckDCVersions, Line 778: failOnError=True, Line 779: errMsg=MSG_ERROR_CONNECT_DB, Line 780: envDict=env, Done Line 781: ) Line 782: queryCheckClusterVersions="SELECT compatibility_version FROM vds_groups;" Line 783: clusterVersions, rc = utils.execRemoteSqlCommand( Line 784: userName=SERVER_ADMIN, Line 787: dbName=basedefs.DB_NAME, Line 788: sqlQuery=queryCheckClusterVersions, Line 789: failOnError=True, Line 790: errMsg=MSG_ERROR_CONNECT_DB, Line 791: envDict=env, Done Line 792: ) Line 793: Line 794: for versions in dcVersions, clusterVersions: Line 795: if oldversion in versions: -- To view, visit http://gerrit.ovirt.org/8135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d44297725d7270982e8724e4aeefda8bc7a88e2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
