Moti Asayag has posted comments on this change. Change subject: engine: Ignore 'cfg' entries for cluster version >= 3.6 ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/36343/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BootProtocolResolver.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BootProtocolResolver.java: Line 26: protected abstract boolean bootProtocolDhcp(); Line 27: Line 28: protected abstract boolean bootProtocolStatic(); Line 29: Line 30: public void resolve() { just noticed jenkins complains about this one. i think it make sense to declare this method with final as a template method. Line 31: if (entry == null) { Line 32: return; Line 33: } Line 34: -- To view, visit https://gerrit.ovirt.org/36343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If434111561aefab3d5d358a97331bcf3159f3484 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
