Moti Asayag has posted comments on this change. Change subject: engine: Ignore 'cfg' entries for cluster version >= 3.6 ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/36343/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1753: } Line 1754: Line 1755: private static void addBootProtocol(Map<String, Object> entry, VDS host, VdsNetworkInterface iface) { Line 1756: BootProtocolResolver resolver = Line 1757: FeatureSupported.cfgEntriesDeprecated(host.getVdsGroupCompatibilityVersion()) this static class is an awful thing :-) we've just resolved this property for other bunch of nics and now there is another need to re-evaluate it again. don't have any smarter way with the current static way the class is built. Line 1758: ? new NoCfgBootProtocolResolver(entry, iface, host) Line 1759: : new CfgBootProtocolResolver(entry, iface, host); Line 1760: resolver.resolve(); Line 1761: } -- To view, visit https://gerrit.ovirt.org/36343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If434111561aefab3d5d358a97331bcf3159f3484 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
