Alona Kaplan has posted comments on this change.

Change subject: engine: adding getIdsOfHostsWithStatus to VdsDynamicDao
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40231/1/packaging/dbscripts/vds_sp.sql
File packaging/dbscripts/vds_sp.sql:

Line 983:    AS $procedure$
Line 984: BEGIN
Line 985:    RETURN QUERY SELECT vds_id
Line 986:    FROM vds_dynamic
Line 987:    WHERE status = v_status;
> please add a index on status for vds_dynamic to prevent table scan
Done
Line 988: END; $procedure$
Line 989: LANGUAGE plpgsql;
Line 990: 
Line 991: 


-- 
To view, visit https://gerrit.ovirt.org/40231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I768162390c8bd334116747702f80ca8f91667781
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to