Eli Mesika has posted comments on this change. Change subject: engine: adding getIdsOfHostsWithStatus to VdsDynamicDao ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40231/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 302: } Line 303: Line 304: @Override Line 305: public List<Guid> getIdsOfHostsWithStatus(VDSStatus status) { Line 306: return getCallsHandler().executeReadList("getIdsOfHostsWithStatus", Although SP names are not case-sensitive , worth to call this GetIdsOfHostsWithStatus as in the SP file Line 307: createGuidMapper(), Line 308: getCustomMapSqlParameterSource() Line 309: .addValue("status", status.getValue())); Line 310: } -- To view, visit https://gerrit.ovirt.org/40231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768162390c8bd334116747702f80ca8f91667781 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
