Maor Lipchuk has posted comments on this change. Change subject: core: support Cinder disks on run VM ......................................................................
Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/39657/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 414: Line 415: List<String> hostAddresses = (ArrayList<String>) connectionInfoData.get("hosts"); Line 416: List<String> hostPorts = (ArrayList<String>) connectionInfoData.get("ports"); Line 417: List<Map<String, Object>> hosts = new ArrayList<>(); Line 418: for (int i = 0; i < hostAddresses.size(); i++) { Please co consider to add a comment about the synced assurance by Cinder Line 419: Map<String, Object> hostMap = new HashMap<>(); Line 420: hostMap.put(VdsProperties.NetworkDiskName, hostAddresses.get(i)); Line 421: hostMap.put(VdsProperties.NetworkDiskPort, hostPorts.get(i)); Line 422: hostMap.put(VdsProperties.NetworkDiskTransport, VdsProperties.Tcp); -- To view, visit https://gerrit.ovirt.org/39657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52521834d049f22c2e9f183b2c57ae558853cfa4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
