Maor Lipchuk has posted comments on this change. Change subject: core: support Cinder disks on run VM ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/39657/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 404: return; Line 405: } Line 406: switch (cinderVolumeDriver) { Line 407: case RBD: Line 408: String path = (String) cinderDisk.getCinderConnectionInfo().getData().get("name"); > do you mean extract it to variable? yes Line 409: struct.put(VdsProperties.Path, path); Line 410: struct.put(VdsProperties.Format, VolumeFormat.RAW.toString().toLowerCase()); Line 411: struct.put(VdsProperties.PropagateErrors, PropagateErrors.Off.toString().toLowerCase()); Line 412: struct.put(VdsProperties.Protocol, cinderDisk.getCinderConnectionInfo().getDriverVolumeType()); Line 417: List<Map<String, Object>> hosts = new ArrayList<>(); Line 418: for (int i = 0; i < hostAddresses.size(); i++) { Line 419: Map<String, Object> hostMap = new HashMap<>(); Line 420: hostMap.put(VdsProperties.NetworkDiskName, hostAddresses.get(i)); Line 421: hostMap.put(VdsProperties.NetworkDiskPort, hostPorts.get(i)); > Cinder assures synced order ack, perhaps it would be nice to add a comment that Cinder assures this Line 422: hostMap.put(VdsProperties.NetworkDiskTransport, VdsProperties.Tcp); Line 423: hosts.add(hostMap); Line 424: } Line 425: struct.put(VdsProperties.NetworkDiskHosts, hosts); -- To view, visit https://gerrit.ovirt.org/39657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52521834d049f22c2e9f183b2c57ae558853cfa4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
