Yedidyah Bar David has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40152/3/packaging/services/ovirt-engine/ovirt-engine.py File packaging/services/ovirt-engine/ovirt-engine.py: Line 254: Line 255: if os.path.exists(jbossConfigFile): Line 256: # Remove service configuration on each setup execution as provided Line 257: # JBoss could be changed Line 258: os.remove(jbossConfigFile) I'd rather not change /usr during runtime. Perhaps call this function _getJBossConfigFile (or also Name) and process it directly by _processTemplate below? Do we need this symlink for anything else? Can't find where, but if we do, we should keep the symlink in /var and not in /usr . Line 259: Line 260: os.symlink( Line 261: os.path.join( Line 262: configDir, Line 458: ) Line 459: ) Line 460: Line 461: jbossConfigFile = self._processTemplate( Line 462: template=os.path.join( e.g. template=_getJBossConfigFileName(engineargs) Line 463: os.path.dirname(sys.argv[0]), Line 464: 'ovirt-engine.xml.in', Line 465: ), Line 466: dir=jbossConfigDir, -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
