Alon Bar-Lev has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40157/2/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 65: public Map<String, Object> parse(List<String> args) { Line 66: List<Object> others = new ArrayList<>(); Line 67: List<Throwable> errors = new ArrayList<>(); Line 68: Map<String, Object> argMap = new HashMap<>(); Line 69: args.addAll(0, defaults); > Not sure what you mean. It goes via convertor in parseProperties. can you please refer me where the default is actually converted? Line 70: Line 71: while(!args.isEmpty()) { Line 72: String arg = args.get(0); Line 73: if(!arg.startsWith(LONG_PREFIX)) { Line 196: try { Line 197: argument.setConvert( Line 198: // default value for no_argument is boolean, for every other it's String Line 199: argument.getType() != ArgumentType.no_argument ? Line 200: Boolean.class this can be set by user Line 201: : Line 202: Class.forName( Line 203: getArgAttrValue(arg, "convert"), Line 204: true, -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
