Alon Bar-Lev has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40157/3/backend/manager/modules/uutils/src/main/resources/org/ovirt/engine/core/uutils/cli/parser/defaults.properties File backend/manager/modules/uutils/src/main/resources/org/ovirt/engine/core/uutils/cli/parser/defaults.properties: Line 16: # argument can be specified more times, it will store list of values Line 17: arg.multivalue = false Line 18: # If argument is of type no_argument set it value arg.value and convert to java.lang.Boolean if argument is not provided Line 19: # if argument is provided set it's value to true Line 20: arg.value = false this should be commented so default will be null not sure I understand this comment... this value should be set based on converter when value is not available, for example: no_argument or optional_arguments when value was not provided, so in summary when value is not provided this value should be set... as required_argument must have value anyway... Line 21: # if argument is mandatory and not specified set it's value to arg.default, by default it's none, Line 22: # so if argument is mandatory and has no default value parsing will fail on IllegalArgumentException Line 23: #arg.default = Line 24: # will be print as first, should contain usage of program/module/action -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
