Martin Mucha has posted comments on this change. Change subject: webadmin: use UpdateAndReorderVmNicsCommand ......................................................................
Patch Set 16: (4 comments) 'rebasing problem' fixed. About three duplicate classes: these were created by copy-pasting, that's certain. But they're not strictly same. I dont know how to remove two of them since I don't know if/how they can be unified. Can you help me with that tom? https://gerrit.ovirt.org/#/c/35193/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 1977: Line 1978: return updateVmParams; Line 1979: } Line 1980: Line 1981: public static void buildVmOnSave(UnitVmModel model, VM vm) { > this got here due to merging mistake I'd say Done Line 1982: BuilderExecutor.build(model, vm.getStaticData(), new FullUnitToVmBaseBuilder()); Line 1983: BuilderExecutor.build(model, vm, new VmSpecificUnitToVmBuilder()); Line 1984: } Line 1985: Line 1982: BuilderExecutor.build(model, vm.getStaticData(), new FullUnitToVmBaseBuilder()); Line 1983: BuilderExecutor.build(model, vm, new VmSpecificUnitToVmBuilder()); Line 1984: } Line 1985: Line 1986: protected boolean balloonEnabled(UnitVmModel model) { > same Done Line 1987: return model.getMemoryBalloonDeviceEnabled().getEntity() Line 1988: && model.getSelectedCluster().getCompatibilityVersion().compareTo(BALLOON_DEVICE_MIN_VERSION) >= 0; Line 1989: } Line 1990: Line 1987: return model.getMemoryBalloonDeviceEnabled().getEntity() Line 1988: && model.getSelectedCluster().getCompatibilityVersion().compareTo(BALLOON_DEVICE_MIN_VERSION) >= 0; Line 1989: } Line 1990: Line 1991: protected void setVmWatchdogToParams(final UnitVmModel model, VmManagementParametersBase updateVmParams) { > same Done Line 1992: VmWatchdogType wdModel = model.getWatchdogModel().getSelectedItem(); Line 1993: updateVmParams.setUpdateWatchdog(true); Line 1994: if (wdModel != null) { Line 1995: VmWatchdog vmWatchdog = new VmWatchdog(); Line 1998: updateVmParams.setWatchdog(vmWatchdog); Line 1999: } Line 2000: } Line 2001: Line 2002: protected void setRngDeviceToParams(UnitVmModel model, VmManagementParametersBase parameters) { > same Done Line 2003: parameters.setUpdateRngDevice(true); Line 2004: parameters.setRngDevice(model.getIsRngEnabled().getEntity() ? model.generateRngDevice() : null); Line 2005: } Line 2006: -- To view, visit https://gerrit.ovirt.org/35193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide74e4a620e4d6175cbcdeccf72403991b0077b8 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
