Tomas Jelinek has posted comments on this change. Change subject: webadmin: use UpdateAndReorderVmNicsCommand ......................................................................
Patch Set 16: (7 comments) https://gerrit.ovirt.org/#/c/35193/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java: Line 435: //TODO MM: Also note, that all descendants adds 'updateActionAvailability' in their cancel method so it's called twice and Line 436: //TODO MM: also 'setWindow(null);' is always present. Line 437: //TODO MM: Potentially missing/extra operations are 'cancelConfirmation(); setGuideContext(null);' in VmListModelUpdateAndReorderVmNicsAsyncCallbackWhenVmtGuidIsEmpty.succeeded() Line 438: Line 439: public class VmListModelUpdateAndReorderVmNicsAsyncCallback extends BasicIFrontendActionAsyncCallback { this seems to not have anything in common with "UpdateAndReorderNics" - please rename accordingly Line 440: Line 441: private final UnitVmModel unitVmModel; Line 442: private final Guid idOfVmToBeUpdated; Line 443: Line 462: executeDiskModifications(idOfVmToBeUpdated, unitVmModel); Line 463: } Line 464: } Line 465: Line 466: private class VmListModelUpdateAndReorderVmNicsAsyncCallbackWhenVmtGuidIsEmpty extends BasicIFrontendActionAsyncCallback { same Line 467: Line 468: private final Guid idOfVmToBeUpdated; Line 469: private final UnitVmModel unitVmModel; Line 470: https://gerrit.ovirt.org/#/c/35193/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java: Line 1411: gettempVm().setId(vmId); Line 1412: model.getInstanceImages().executeDiskModifications(gettempVm()); Line 1413: } Line 1414: Line 1415: //TODO MM: duplicity. yeah, please unify :) Line 1416: private class UserPortalListModelUpdateAndReorderVmNicsAsyncCallback extends BasicIFrontendActionAsyncCallback { Line 1417: Line 1418: private final Guid idOfVmToBeUpdated; Line 1419: private final UnitVmModel unitVmModel; https://gerrit.ovirt.org/#/c/35193/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 1977: Line 1978: return updateVmParams; Line 1979: } Line 1980: Line 1981: public static void buildVmOnSave(UnitVmModel model, VM vm) { this got here due to merging mistake I'd say Line 1982: BuilderExecutor.build(model, vm.getStaticData(), new FullUnitToVmBaseBuilder()); Line 1983: BuilderExecutor.build(model, vm, new VmSpecificUnitToVmBuilder()); Line 1984: } Line 1985: Line 1982: BuilderExecutor.build(model, vm.getStaticData(), new FullUnitToVmBaseBuilder()); Line 1983: BuilderExecutor.build(model, vm, new VmSpecificUnitToVmBuilder()); Line 1984: } Line 1985: Line 1986: protected boolean balloonEnabled(UnitVmModel model) { same Line 1987: return model.getMemoryBalloonDeviceEnabled().getEntity() Line 1988: && model.getSelectedCluster().getCompatibilityVersion().compareTo(BALLOON_DEVICE_MIN_VERSION) >= 0; Line 1989: } Line 1990: Line 1991: setVmWatchdogToParams same Line 2002: setRngDeviceToParams same -- To view, visit https://gerrit.ovirt.org/35193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide74e4a620e4d6175cbcdeccf72403991b0077b8 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
