Nir Soffer has posted comments on this change.

Change subject: reorg repoclosure + tests
......................................................................


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/39249/17/jobs/packaging/test_repo_closure_check.sh
File jobs/packaging/test_repo_closure_check.sh:

Line 21:     unset COPR
Line 22:     ## check non existing vars have been set:
Line 23:     validation
Line 24:     [ "${output}" = "" ]
Line 25:     [ ! -z "${BASE_URL}" ]
Please replace ! -z with -n
Line 26:     [ ! -z "${CENTOS_MIRROR}" ]
Line 27:     [ ! -z "${EPEL_MIRROR}" ]
Line 28:     [ ! -z "${FEDORA_MIRROR}" ]
Line 29:     [ ! -z "${GLUSTER_MIRROR}" ]


-- 
To view, visit https://gerrit.ovirt.org/39249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363
Gerrit-PatchSet: 17
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Max Kovgan <m...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Max Kovgan <m...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to