Ori Liel has posted comments on this change. Change subject: restapi: Fix possible version mismatch (#1206068) ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40085/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java: Line 291: } Line 292: Line 293: private API addSystemVersion(API api) { Line 294: String productVersion = getConfigurationValueDefault(String.class, Line 295: ConfigurationValues.ProductRPMVersion); > Can we move this to the new query as well? Ideally this command should retu Unless there's some additional logic involved, we don't usually use designated queries to get configuration values. So IMHO using the generic method as we do here, is enough. Also, we'd need a new container class that holds Version and String for the return value. So I think we can live without it, but I have no problem making the change if you still think it's important. Line 296: BrandingManager obrand = BrandingManager.getInstance(); Line 297: api.setProductInfo(new ProductInfo()); Line 298: api.getProductInfo().setName(obrand.getMessage("obrand.backend.product")); Line 299: api.getProductInfo().setVendor(obrand.getMessage("obrand.backend.vendor")); -- To view, visit https://gerrit.ovirt.org/40085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bd123c2352db229e52bdbd3f1e2db4ac72018a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
