Juan Hernandez has posted comments on this change. Change subject: restapi: Fix possible version mismatch (#1206068) ......................................................................
Patch Set 2: (1 comment) The BackendCapabilitiesResource should also be changed to use the new query instead of the VdcVersion configuration value. https://gerrit.ovirt.org/#/c/40085/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java: Line 291: } Line 292: Line 293: private API addSystemVersion(API api) { Line 294: String productVersion = getConfigurationValueDefault(String.class, Line 295: ConfigurationValues.ProductRPMVersion); Can we move this to the new query as well? Ideally this command should return the "version" object and the "full_version" string, and the RESTAPI should just take and display them. Line 296: BrandingManager obrand = BrandingManager.getInstance(); Line 297: api.setProductInfo(new ProductInfo()); Line 298: api.getProductInfo().setName(obrand.getMessage("obrand.backend.product")); Line 299: api.getProductInfo().setVendor(obrand.getMessage("obrand.backend.vendor")); -- To view, visit https://gerrit.ovirt.org/40085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bd123c2352db229e52bdbd3f1e2db4ac72018a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
