Allon Mureinik has posted comments on this change.
Change subject: core: Disabling plug disks command during take snapshot
(#844440)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 121:
Line 122: if (vdcReturnValue.getSucceeded()) {
Line 123:
getTaskIdList().addAll(vdcReturnValue.getInternalTaskIdList());
Line 124: } else {
Line 125: freeLock();
consider putting this in a finally block
Line 126: throw new
VdcBLLException(vdcReturnValue.getFault().getError(),
Line 127:
"CreateAllSnapshotsFromVmCommand::executeVmCommand: Failed to create
snapshot!");
Line 128: }
Line 129: }
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-02 13:13:26 +0200
Line 4: Commit: Tal Nisan <[email protected]>
Line 5: CommitDate: 2012-10-02 13:15:49 +0200
Line 6:
Line 7: core: Disabling plug disks command during take snapshot (#844440)
s/take snapshot/snashoting
Line 8:
Line 9: https://bugzilla.redhat.com/844440
Line 10:
Line 11: Lock the VM entity during take snapshot to avoid plug/unplug disk
Line 5: CommitDate: 2012-10-02 13:15:49 +0200
Line 6:
Line 7: core: Disabling plug disks command during take snapshot (#844440)
Line 8:
Line 9: https://bugzilla.redhat.com/844440
Use the Bug-Url: field, as per the template.
Line 10:
Line 11: Lock the VM entity during take snapshot to avoid plug/unplug disk
Line 12: command to run and fail during the action
Line 13:
Line 7: core: Disabling plug disks command during take snapshot (#844440)
Line 8:
Line 9: https://bugzilla.redhat.com/844440
Line 10:
Line 11: Lock the VM entity during take snapshot to avoid plug/unplug disk
s/take snapshot/snashoting
Line 12: command to run and fail during the action
Line 13:
Line 14: Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d
--
To view, visit http://gerrit.ovirt.org/8298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
