Tal Nisan has uploaded a new change for review. Change subject: core: Disabling plug disks command during take snapshot (#844440) ......................................................................
core: Disabling plug disks command during take snapshot (#844440) https://bugzilla.redhat.com/844440 Lock the VM entity during take snapshot to avoid plug/unplug disk command to run and fail during the action Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d Signed-off-by: Tal Nisan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/8298/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index ecee40b..ddcd5d0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -95,7 +95,6 @@ getVm(), getCompensationContext()); - freeLock(); setActionReturnValue(createdSnapshotId); if (getDisksList().isEmpty()) { @@ -123,11 +122,12 @@ if (vdcReturnValue.getSucceeded()) { getTaskIdList().addAll(vdcReturnValue.getInternalTaskIdList()); } else { + freeLock(); throw new VdcBLLException(vdcReturnValue.getFault().getError(), "CreateAllSnapshotsFromVmCommand::executeVmCommand: Failed to create snapshot!"); } } - + freeLock(); setSucceeded(true); } } -- To view, visit http://gerrit.ovirt.org/8298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
