Moti Asayag has uploaded a new change for review. Change subject: webadmin: Adjust mac address field size ......................................................................
webadmin: Adjust mac address field size The patch adjusts the column width of longer than standard mac address field and show the entire content of it as a tool tip. Change-Id: I9f7736300652a20dcd6e785e6836de66c4d97f0c Bug-Url: https://bugzilla.redhat.com/823397 Signed-off-by: Moti Asayag <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/8300/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java index 8dda3e6..cf043ae 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java @@ -7,6 +7,7 @@ import org.ovirt.engine.ui.common.widget.renderer.SumUpRenderer; import org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterface; import org.ovirt.engine.ui.webadmin.gin.ClientGinjectorProvider; +import org.ovirt.engine.ui.webadmin.widget.label.LabelWithToolTip; import com.google.gwt.dom.client.Style; import com.google.gwt.dom.client.Style.BorderStyle; @@ -79,7 +80,8 @@ row.setWidget(0, 2, new Label(hostInterface.getAddress())); // MAC - row.setWidget(0, 3, new Label(hostInterface.getMAC())); + LabelWithToolTip macLabel = new LabelWithToolTip(hostInterface.getMAC(), 17); + row.setWidget(0, 3, macLabel); // Speed row.setWidget(0, 4, new Label() { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java new file mode 100644 index 0000000..28280f9 --- /dev/null +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java @@ -0,0 +1,21 @@ +package org.ovirt.engine.ui.webadmin.widget.label; + +import com.google.gwt.user.client.ui.Label; + +public class LabelWithToolTip extends Label { + + public LabelWithToolTip(String text, int length) { + super(text); + + if (length > -1 && text.length() > length) { + setText(text.substring(0, length - 3) + "..."); //$NON-NLS-1$ + } + + setTitle(text); + } + + public LabelWithToolTip(String text) { + this(text, -1); + } + +} -- To view, visit http://gerrit.ovirt.org/8300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f7736300652a20dcd6e785e6836de66c4d97f0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
