Roy Golan has posted comments on this change.

Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806)
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BootSequence.java
Line 36:             mappings.put(error.getValue(), error);
Line 37:         }
Line 38: 
Line 39:         // since the EnumSet.of(BootSequence) (e.g. EnumSet.of(C) )can 
not be called from the constructor
Line 40:         // the BootSequence components need to be initialized here.
+1 for 3 beacuse we just need to contains. the actual order doesn't matter and 
you did nicely by having a descriptive constructor.
Line 41:         C.setComposedOf(C);
Line 42:         D.setComposedOf(D);
Line 43:         N.setComposedOf(N);
Line 44:         DC.setComposedOf(D, C);


--
To view, visit http://gerrit.ovirt.org/8077
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d39f8559bcffdc154b0b2c01d5303cf2ff1e1a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to