Arik Hadas has posted comments on this change. Change subject: engine: Cleanup the vfs when the vm is down and refresh host if needed ......................................................................
Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/38624/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java: Line 28: @NonTransactiveCommandAttribute Line 29: public class ClearNonResponsiveVdsVmsCommand<T extends VdsActionParameters> extends VdsCommand<T> { Line 30: Line 31: @Inject Line 32: HostDeviceManager hostDeviceManger; unused? Line 33: Line 34: /** Line 35: * Constructor for command creation when compensation is applied on startup Line 36: * Line 57: protected void executeCommand() { Line 58: List<VM> vms = getVmDAO().getAllRunningForVds(getVdsId()); Line 59: Collections.sort(vms, Collections.reverseOrder(new VmsComparer())); Line 60: List<Guid> autoStartVmIdsToRerun = new ArrayList<>(); Line 61: List<Guid> vmIds = new ArrayList<>(); how about s/vmIds/movedToDownVmIds ? Line 62: for (VM vm : vms) { Line 63: if (vm.isAutoStartup()) { Line 64: autoStartVmIdsToRerun.add(vm.getId()); Line 65: } https://gerrit.ovirt.org/#/c/38624/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java: Line 95: * @param vms list of VM to stopped/restarted Line 96: */ Line 97: public void restartVms(List<VM> vms) { Line 98: List<Guid> autoStartVmIdsToRerun = new ArrayList<>(); Line 99: List<Guid> vmIds = new ArrayList<>(); how about s/vmIds/movedToDownVmIds ? Line 100: // restart all running vms of a failed vds. Line 101: for (VM vm : vms) { Line 102: destroyVmOnDestination(vm); Line 103: VDSReturnValue returnValue = Backend.getInstance().getResourceManager().RunVdsCommand( -- To view, visit https://gerrit.ovirt.org/38624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f861a451f4e0961ec122e4c2594081ea6dc71b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
