Michael Kublin has uploaded a new change for review.
Change subject: core: Removed un needed run of code in Suppres mode
......................................................................
core: Removed un needed run of code in Suppres mode
The following patch will remove un needed run of code in Suppress mode.
The following code is already run with out scope of any transaction, no
need explicity to remove it.
Motivation: less code - better redability, less look ups - better performance,
less anonymous class - better memory.
Change-Id: I87050e78abf0e468ebae5348f6e01c9ce46c7581
Bug-Url: NA
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 13 insertions(+), 28 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/8233/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
index 649b007..4dc95a8 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
@@ -110,18 +110,11 @@
}
public static void Init() {
-
- TransactionSupport.executeInScope(TransactionScopeOption.Suppress, new
TransactionMethod<Object>() {
- @Override
- public Object runInTransaction() {
- for (storage_pool sp :
DbFacade.getInstance().getStoragePoolDao().getAll()) {
- if (!_irsProxyData.containsKey(sp.getId())) {
- _irsProxyData.put(sp.getId(), new
IrsProxyData(sp.getId()));
- }
- }
- return null;
+ for (storage_pool sp :
DbFacade.getInstance().getStoragePoolDao().getAll()) {
+ if (!_irsProxyData.containsKey(sp.getId())) {
+ _irsProxyData.put(sp.getId(), new IrsProxyData(sp.getId()));
}
- });
+ }
}
public void RemoveIrsProxy() {
@@ -197,29 +190,21 @@
@OnTimerMethodAnnotation("_updatingTimer_Elapsed")
public void _updatingTimer_Elapsed() {
try {
-
synchronized (syncObj) {
if (!_disposed) {
-
TransactionSupport.executeInScope(TransactionScopeOption.Suppress,
- new TransactionMethod<Object>() {
- @Override
- public Object runInTransaction() {
- storage_pool storagePool =
DbFacade.getInstance().getStoragePoolDao()
- .get(_storagePoolId);
- if (storagePool != null
- && (storagePool.getstatus() ==
StoragePoolStatus.Up
- ||
storagePool.getstatus() == StoragePoolStatus.Problematic || storagePool
- .getstatus() ==
StoragePoolStatus.Contend)) {
- ProceedStoragePoolStats();
- }
- return null;
- }
- });
+ storage_pool storagePool =
DbFacade.getInstance().getStoragePoolDao()
+ .get(_storagePoolId);
+ if (storagePool != null
+ && (storagePool.getstatus() ==
StoragePoolStatus.Up
+ || storagePool.getstatus() ==
StoragePoolStatus.Problematic || storagePool
+ .getstatus() ==
StoragePoolStatus.Contend)) {
+ ProceedStoragePoolStats();
+ }
+
}
}
} catch (java.lang.Exception ex) {
}
-
}
private int _errorAttempts;
--
To view, visit http://gerrit.ovirt.org/8233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87050e78abf0e468ebae5348f6e01c9ce46c7581
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
