Michael Kublin has uploaded a new change for review.
Change subject: core: Removed un needed run of code in Suppres mode
......................................................................
core: Removed un needed run of code in Suppres mode
The following patch will remove un needed run of code in Suppress mode.
The following code is already run with out scope of any transaction, no
need explicity to remove it.
Motivation: less code - better redability, less look ups - better performance,
less anonymous class - better memory.
Change-Id: Ia2e2ec7a0f8ba5b540582343980714d678575328
Bug-Url: NA
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/8232/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index a68fdd2..a3898f8 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -254,14 +254,7 @@
_vds = vds;
_firstStatus = _vds.getstatus();
monitoringStrategy = getMonitoringStrategyForVds(vds);
- _vmDict =
-
TransactionSupport.executeInScope(TransactionScopeOption.Suppress,
- new TransactionMethod<Map<Guid, VM>>() {
- @Override
- public Map<Guid, VM> runInTransaction() {
- return
getDbFacade().getVmDao().getAllRunningByVds(_vds.getId());
- }
- });
+ _vmDict = getDbFacade().getVmDao().getAllRunningByVds(_vds.getId());
for (VM vm : _vmDict.values()) {
if (vm.isStatusUp() && vm.getstatus() != VMStatus.Up) {
--
To view, visit http://gerrit.ovirt.org/8232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2e2ec7a0f8ba5b540582343980714d678575328
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
