Itamar Heim has posted comments on this change. Change subject: Log stacktraces for failed VDSCommandBase calls ......................................................................
Patch Set 1: it is ok to print an exception only for an unexpected error. every stack trace means "something bad/unecpected happened - i should ask the community, call support, etc.). since logException happens in "known" flows as well, the stack trace should be filtered to be printed only in unexepcted flows. so i'm fine with printing the stack trace, but only for unexpected errors (i.e., not for things like host is non responsive) -- To view, visit http://gerrit.ovirt.org/8072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
