Juan Hernandez has posted comments on this change. Change subject: restapi: Show full Gluster storage domain details ......................................................................
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39810/3/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java: Line 389: if (cnx.getNfsTimeo() != null) { Line 390: model.getStorage().setNfsTimeo(cnx.getNfsTimeo().intValue()); Line 391: } Line 392: if (cnx.getNfsVersion() != null) { Line 393: model.getStorage().setNfsVersion(StorageDomainMapper.map(cnx.getNfsVersion(), null)); Why "model.getStorage()" instead of just "storage"? Line 394: } Line 395: } Line 396: } Line 397: -- To view, visit https://gerrit.ovirt.org/39810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2294ab6a0256f5c8bc5f48e04dada506500f79d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
