Juan Hernandez has posted comments on this change. Change subject: restapi: Show full Gluster storage domain details ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39810/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java: Line 380: } Line 381: if (cnx.getNfsVersion() != null) { Line 382: model.getStorage().setNfsVersion(StorageDomainMapper.map(cnx.getNfsVersion(), null)); Line 383: } Line 384: } > I strongly prefer this variant, but it's Juan's realm - his opinion should I don't have a really good reason to use one method instead of two (or the other way around), so do as you prefer. But I do object about the "case" without "break", or rather about the fallthrought. Can we do the following? case NFS: mapFileDomain(model, entity); mapNFSProperties(model, entity); break; case LOCALFS: case POSIXFS: case GLUSTERFS: mapFileDomain(model, entity); break; This is just a suggestion, I know that things will work anyhow, so I won't block this patch if you don't want to do this. Line 385: Line 386: protected void mapFileDomain(StorageDomain model, Line 387: org.ovirt.engine.core.common.businessentities.StorageDomain entity) { Line 388: final Storage storage = model.getStorage(); -- To view, visit https://gerrit.ovirt.org/39810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2294ab6a0256f5c8bc5f48e04dada506500f79d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
