Tomas Jelinek has posted comments on this change. Change subject: webadmin: fix import/general sub-tab ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/39586/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java: Line 19: import org.ovirt.engine.ui.uicompat.ConstantsManager; Line 20: import org.ovirt.engine.ui.uicompat.EnumTranslator; Line 21: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; Line 22: Line 23: public class VmImportGeneralModel extends AbstractGeneralModel<ImportVmData> { > two reasons: 1: in that case you just need to provide the proper implementation of the ImportVmFromExportDomainPopupView.subTabLayoutPanelSelectionChanged, something like: if (selectedItem != null && selectedItem instanceof ImportVmData) { return ((ImportVmData) selectedItem).getEntity(); } return selectedItem; well, maybe be careful to provide this one only for the specific general tab - not sure. 2: this patch does not make it editable, but even if it did, is there no way to make only this two fields editable without the need to copy paste everything else? Line 24: private static final VmTemplateNameRenderer vmTemplateNameRenderer = new VmTemplateNameRenderer(); Line 25: private static EnumTranslator translator = EnumTranslator.getInstance(); Line 26: Line 27: private String name; https://gerrit.ovirt.org/#/c/39586/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java: Line 23: import com.google.gwt.user.client.ui.Image; Line 24: import com.google.gwt.user.client.ui.Widget; Line 25: Line 26: public class ImportVmGeneralSubTabView extends AbstractSubTabFormView<VM, ImportVmFromExportDomainModel, VmImportGeneralModel> implements SubTabVirtualMachineGeneralPresenter.ViewDef, Editor<VmImportGeneralModel> { Line 27: > since I need it to have VmImportGeneralModelForm which is a bit different, if I see it correctly the only difference is that the SubTabVirtualMachineGeneralView uses VmGeneralModelForm while ImportVmGeneralSubTabView uses VmImportGeneralModelForm. If there is really no more difference than you can just create some method like protected VmGeneralModelForm createForm(... on the SubTabVirtualMachineGeneralView which would return the VmGeneralModelForm(modelProvider) and than override it on ImportVmGeneralSubTabView to return new VmImportGeneralModelForm(modelProvider) (you can do this since the form is defined as @UiField(provided = true)) Line 28: interface ViewUiBinder extends UiBinder<Widget, ImportVmGeneralSubTabView> { Line 29: ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); Line 30: } Line 31: -- To view, visit https://gerrit.ovirt.org/39586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
