Arik Hadas has posted comments on this change. Change subject: webadmin: fix import/general sub-tab ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/39586/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-04-07 09:37:03 +0300 Line 6: Line 7: webadmin: fix import/general sub-tab Line 8: Line 9: The general sub-tab in the import dialog was broken by recent changes in > how was it broken? it didn't show the properties it is supposed to show, that's because the entity type was different than the one it expected (it expected to get a VM as an entity but got ImportVmData) Line 10: the frontend. This patch fixes the sub-tab that shows general Line 11: information about the VM to be imported. Line 12: Line 13: Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e https://gerrit.ovirt.org/#/c/39586/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java: Line 19: import org.ovirt.engine.ui.uicompat.ConstantsManager; Line 20: import org.ovirt.engine.ui.uicompat.EnumTranslator; Line 21: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; Line 22: Line 23: public class VmImportGeneralModel extends AbstractGeneralModel<ImportVmData> { > why have you decided to extend this instead of VmGeneralModel? Now I see lo two reasons: 1. this one operates on ImportVmData and not on VM 2. In VmGeneralModel we only show the VM properties but they are not editable. In import, the name should always be editable (instead of having clone popups) and the operating system should also be editable when importing from external provider Line 24: private static final VmTemplateNameRenderer vmTemplateNameRenderer = new VmTemplateNameRenderer(); Line 25: private static EnumTranslator translator = EnumTranslator.getInstance(); Line 26: Line 27: private String name; https://gerrit.ovirt.org/#/c/39586/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java: Line 23: import com.google.gwt.user.client.ui.Image; Line 24: import com.google.gwt.user.client.ui.Widget; Line 25: Line 26: public class ImportVmGeneralSubTabView extends AbstractSubTabFormView<VM, ImportVmFromExportDomainModel, VmImportGeneralModel> implements SubTabVirtualMachineGeneralPresenter.ViewDef, Editor<VmImportGeneralModel> { Line 27: > also copy pasted from SubTabVirtualMachineGeneralView. Why? since I need it to have VmImportGeneralModelForm which is a bit different, because of the name & operating system being editable, instead of the form used in SubTabVirtualMachineGeneralView Line 28: interface ViewUiBinder extends UiBinder<Widget, ImportVmGeneralSubTabView> { Line 29: ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); Line 30: } Line 31: -- To view, visit https://gerrit.ovirt.org/39586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
