Arik Hadas has posted comments on this change. Change subject: engine: block migration if passthrough vnics exist ......................................................................
Patch Set 3: (1 comment) minor comment, besides that it looks good https://gerrit.ovirt.org/#/c/38891/3/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 201: MIGRATION_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Migration is not supported in this CPU architecture. Line 202: MIGRATION_ON_ERROR_IS_NOT_SUPPORTED=Cannot ${action} ${type}. This resilience policy is not supported in this CPU architecture. Line 203: VM_MIGRATION_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Migration option is not supported in this CPU architecture. Line 204: VM_ID_EXISTS=Cannot ${action} ${type}. VM with the given Id already exists in the system. Line 205: ACTION_TYPE_FAILED_MIGRATION_OF_PASSTHROUGH_VNICS_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Migration option is not supported for VMs containing 'passthrough' VM Network Interfaces (VM: ${vmName}, passthrough interfaces: ${interfaces}). s/Migration option/Migration (see MIGRATION_IS_NOT_SUPPORTED above) Line 206: ACTION_TYPE_FAILED_VM_CANNOT_BE_HIGHLY_AVAILABLE_AND_PINNED_TO_HOST=Cannot ${action} ${type}. A highly available VM cannot be pinned to a specific Host Line 207: ACTION_TYPE_FAILED_VM_GUID_ALREADY_EXIST=Cannot ${action} ${type}. VM with the same identifier already exists. Line 208: ACTION_TYPE_FAILED_VM_ATTACHED_TO_POOL=Cannot ${action} ${type}. VM is attached to a VM Pool. Line 209: ACTION_TYPE_FAILED_NO_AVAILABLE_POOL_VMS=Cannot ${action} ${type}. There are no available VMs in the VM-Pool. -- To view, visit https://gerrit.ovirt.org/38891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab61467f23f4e6684cf51b234faf8c595f279f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
