Moti Asayag has posted comments on this change. Change subject: engine: block migration if passthrough vnics exist ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38891/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java: Line 226: } Line 227: Line 228: /** Line 229: * @return ValidationResult indicating whether a vm contains passthrough vnics Line 230: */ please add unit test to VmValidatorTest Line 231: public ValidationResult vmNotHavingPassthroughVnics() { Line 232: for (VM vm : vms) { Line 233: List<VmNetworkInterface> vnics = Line 234: getDbFacade().getVmNetworkInterfaceDao().getAllForVm(vm.getId()); -- To view, visit https://gerrit.ovirt.org/38891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab61467f23f4e6684cf51b234faf8c595f279f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
