Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/37886/18/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 143: getArgAttrValue(arg, "name") Line 144: ); Line 145: if (argument.getName() == null) { Line 146: throw new IllegalArgumentException( Line 147: String.format("Name of argument '%1$s' have to specified", arg) > have to be specified? if I understand this correctly, this is configuration issue of developer, so we can actually print more information, like the entire property name. Configuration error: Parameter '%s' has no name or something like that. Line 148: ); Line 149: } Line 150: argument.setMetavar( Line 151: getArgAttrValue(arg, "metavar") Line 210: continue; Line 211: } Line 212: if (param.length < 4) { Line 213: throw new IllegalArgumentException( Line 214: String.format("Invalid option '%1$s'", argName) Configuration error: invalid structure for parameter '%s' Line 215: ); Line 216: } Line 217: args.add(param[2]); Line 218: } -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
