mooli tayer has posted comments on this change.

Change subject: extensions test tool: logger
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/37886/18/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java
File 
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java:

Line 143:                 getArgAttrValue(arg, "name")
Line 144:             );
Line 145:             if (argument.getName() == null) {
Line 146:                 throw new IllegalArgumentException(
Line 147:                     String.format("Name of argument '%1$s' have to 
specified", arg)
> if I understand this correctly, this is configuration issue of developer, s
Yep that would have helped me to find the bug I just had faster...
Line 148:                 );
Line 149:             }
Line 150:             argument.setMetavar(
Line 151:                 getArgAttrValue(arg, "metavar")


-- 
To view, visit https://gerrit.ovirt.org/37886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to