Moti Asayag has posted comments on this change. Change subject: engine: scheduling host- find free VF ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37931/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 526: if (hostList == null || hostList.isEmpty()) { Line 527: break; Line 528: } Line 529: filterPolicyUnit.setMemoryChecker(memoryChecker); Line 530: filterPolicyUnit.setHostToVnicToVfMap(hostToVnicToVfMap); i think this is wrong. what basically happens here is enforcement of each PolicyUnit to be aware of functionality which it doesn't concern. This is not the right approach to go. It isn't OO. Setting specific context to specific filter should be either by instantiating it or when building the list of the filters or by adding some "initializeFilter(...)" method or any other variation that doesn't require all of the filters awareness to a specific filter logic. Line 531: List<VDS> currentHostList = new ArrayList<VDS>(hostList); Line 532: hostList = filterPolicyUnit.filter(hostList, vm, parameters, result.getDetails()); Line 533: logFilterActions(currentHostList, Line 534: toIdSet(hostList), -- To view, visit https://gerrit.ovirt.org/37931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
